Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to check and update builder base for new Golang version #1449

Merged
merged 11 commits into from
Jul 12, 2024
Merged

Add script to check and update builder base for new Golang version #1449

merged 11 commits into from
Jul 12, 2024

Conversation

rcrozean
Copy link
Member

@rcrozean rcrozean commented Jun 17, 2024 •
edited
Loading

Issue #, if available:

Description of changes:
This will be called by a periodic to update golang versions in the versions.yaml and null the golang minimal images with the corresponding major versions.

OUTPUT from local run:

diff --git a/EKS_DISTRO_TAG_FILE.yaml b/EKS_DISTRO_TAG_FILE.yaml
index 5c0e278c..04b12c6e 100644
--- a/EKS_DISTRO_TAG_FILE.yaml
+++ b/EKS_DISTRO_TAG_FILE.yaml
@@ -28,12 +28,12 @@ al2:
   eks-distro-minimal-base-golang-compiler-1.20-base: 1.20-2024-05-31-1717182096.2
   eks-distro-minimal-base-golang-compiler-1.20-yum: 1.20-yum-2024-05-31-1717182096.2
   eks-distro-minimal-base-golang-compiler-1.20-gcc: 1.20-gcc-2024-05-31-1717182096.2
-  eks-distro-minimal-base-golang-compiler-1.21-base: 1.21-2024-06-11-1718132503.2
-  eks-distro-minimal-base-golang-compiler-1.21-yum: 1.21-yum-2024-06-11-1718132503.2
-  eks-distro-minimal-base-golang-compiler-1.21-gcc: 1.21-gcc-2024-06-11-1718132503.2
-  eks-distro-minimal-base-golang-compiler-1.22-base: 1.22-2024-06-11-1718132503.2
-  eks-distro-minimal-base-golang-compiler-1.22-yum: 1.22-yum-2024-06-11-1718132503.2
-  eks-distro-minimal-base-golang-compiler-1.22-gcc: 1.22-gcc-2024-06-11-1718132503.2
+  eks-distro-minimal-base-golang-compiler-1.21-base: null
+  eks-distro-minimal-base-golang-compiler-1.21-yum: null
+  eks-distro-minimal-base-golang-compiler-1.21-gcc: null
+  eks-distro-minimal-base-golang-compiler-1.22-base: null
+  eks-distro-minimal-base-golang-compiler-1.22-yum: null
+  eks-distro-minimal-base-golang-compiler-1.22-gcc: null
   eks-distro-minimal-base-nodejs-compiler-16-base: 16-2024-05-01-1714590102.2
   eks-distro-minimal-base-nodejs-compiler-16-yum: 16-yum-2024-05-01-1714590102.2
   eks-distro-minimal-base-nodejs-compiler-16-gcc: 16-gcc-2024-05-15-1715799651.2
@@ -76,12 +76,12 @@ al2023:
   eks-distro-minimal-base-golang-compiler-1.20-base: 1.20-2024-06-11-1718089305.2023
   eks-distro-minimal-base-golang-compiler-1.20-yum: 1.20-yum-2024-06-11-1718089305.2023
   eks-distro-minimal-base-golang-compiler-1.20-gcc: 1.20-gcc-2024-06-11-1718089305.2023
-  eks-distro-minimal-base-golang-compiler-1.21-base: 1.21-2024-06-12-1718204758.2023
-  eks-distro-minimal-base-golang-compiler-1.21-yum: 1.21-yum-2024-06-12-1718204758.2023
-  eks-distro-minimal-base-golang-compiler-1.21-gcc: 1.21-gcc-2024-06-12-1718204758.2023
-  eks-distro-minimal-base-golang-compiler-1.22-base: 1.22-2024-06-12-1718204758.2023
-  eks-distro-minimal-base-golang-compiler-1.22-yum: 1.22-yum-2024-06-12-1718204758.2023
-  eks-distro-minimal-base-golang-compiler-1.22-gcc: 1.22-gcc-2024-06-12-1718204758.2023
+  eks-distro-minimal-base-golang-compiler-1.21-base: null
+  eks-distro-minimal-base-golang-compiler-1.21-yum: null
+  eks-distro-minimal-base-golang-compiler-1.21-gcc: null
+  eks-distro-minimal-base-golang-compiler-1.22-base: null
+  eks-distro-minimal-base-golang-compiler-1.22-yum: null
+  eks-distro-minimal-base-golang-compiler-1.22-gcc: null
   eks-distro-minimal-base-nodejs-compiler-16-base: 16-2024-06-11-1718089305.2023
   eks-distro-minimal-base-nodejs-compiler-16-yum: 16-yum-2024-06-11-1718089305.2023
   eks-distro-minimal-base-nodejs-compiler-16-gcc: 16-gcc-2024-06-11-1718089305.2023

diff --git a/builder-base/versions.yaml b/builder-base/versions.yaml
index 232e9156..b30f5241 100644
--- a/builder-base/versions.yaml
+++ b/builder-base/versions.yaml
@@ -6,8 +6,8 @@ GOLANG_VERSION_117: 1.17.13-6
 GOLANG_VERSION_118: 1.18.10-8
 GOLANG_VERSION_119: 1.19.13-14
 GOLANG_VERSION_120: 1.20.14-16
-GOLANG_VERSION_121: 1.21.11-12
-GOLANG_VERSION_122: 1.22.4-4
+GOLANG_VERSION_121: 1.21.12-0
+GOLANG_VERSION_122: 1.22.5-0
 GO_LICENSES_VERSION: v1.6.0
 GOVC_VERSION: 0.34.2
 GO_VULN_CHECK_VERSION: v1.0.1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rcrozean rcrozean mentioned this pull request Jun 17, 2024
Merged
@vineeth-bandi
Copy link
Member

/lgtm

@bhavi-koduru
Copy link
Member

/lgtm

@rcrozean rcrozean mentioned this pull request Jul 9, 2024
Merged
@github-actions github-actions bot added the minimal-image Changes related to the minimal-images or tooling label Jul 11, 2024
@rcrozean rcrozean force-pushed the golangBumpCheckScript branch from dce3212 to 1a96f3e Compare July 11, 2024 20:01
@vineeth-bandi
Copy link
Member

/lgtm

@rcrozean
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rcrozean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 607942e into aws:main Jul 12, 2024
40 checks passed
@rcrozean rcrozean deleted the golangBumpCheckScript branch July 15, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vineeth-bandi vineeth-bandi

@bhavi-koduru bhavi-koduru

Labels
approved builder-base lgtm minimal-image Changes related to the minimal-images or tooling size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rcrozean @vineeth-bandi @bhavi-koduru @eks-distro-bot